procedure TCustomMSTable.PrepareSQL and FastReport5

[LHSoft]

Hello,
there is an error in proc above in this line (4682):

Code: Select all

if (DataSource <> nil) and (FMasterFields <> '') and (FDetailFields <> '') and not DataSource.DataSet.Active

DataSource.DataSet is nil when opening a table in FR5 with master-detail set.

so now question is: should DataSource.DataSet not be nil or can I modify the condition til your next version so DataSource.DataSet.active will not be queried if DataSource.DataSet is nil?

best regards
Hans

[azyk]

We can't reproduce the described behavior. Please try to compose a small sample to demonstrate the problem and send it to andreyz*devart*com .

[LHSoft]

Hello,

Email is sent,
FastReport support got the error too.

best regards
Hans

[LHSoft]

By the way:
I have interim avoided this error:

Code: Select all

  if (DataSource <> nil) and (FMasterFields <> '') and (FDetailFields <> '')
  then begin
    if DataSource.DataSet <> nil then
      if DataSource.DataSet.Active then exit;

    MasterPos := 1;
    while True do begin
      MasterName := ExtractFieldName(FMasterFields, MasterPos);
      if MasterName <> '' then begin
        Param := Params.FindParam(MasterName);
        if Param <> nil then
          Param.DataType := ftString;
      end
      else
        break;
    end;
  end;

[azyk]

Thank you for the provided sample. We have reproduced the described problem and fixed it.

[LHSoft]

Hello,

thanks.
In new version 7.2.8 error still exists.

By the way:
in fs_isdacrtti.pas of your FR5 source code OLEDBAccess (->EMSError) is missing in the uses section.

best regards
Hans

[azyk]

This fix wasn't included in SDAC 7.2.8, it will be included in the next build of SDAC.

Thank you for your note. We have added the OLEDBAccess unit in the uses section of fs_isdacrtti.pas. This modification will be included in the next SDAC build too.

[LHSoft]

perfettamente

thanks
Hans