Bugs found in source code of OraSmart
Posted: Tue 16 May 2006 07:24
Hi!
We think, we found 2 bugs in OraSmart. Please confirm:
1. OraSmart RegisterDataSet lines 450-463:
450: repeat
iPos := Pos(';', DependEvents);
...
463: until iPos = 0;
where DependEvents is a property of TCustomSmartQuery.
So if DependEvents contains ';' then it goes infinitely.
2.OraSmart InternalPost lines 1311-1321:
(internal procedure DoRestoreReadOnly)
1315: SetLength(SaveReadOnly, 0);
1316: DisableControls;
1317: for i := 0 to FieldCount - 1 do
1318: if Fields.FieldKind = fkData then
-- here should be Fields.Fields...
1319: Fields.ReadOnly := SaveReadOnly;
-- here should be Fields.Fields..., also SaveReadOnly is empty here.
We think, we found 2 bugs in OraSmart. Please confirm:
1. OraSmart RegisterDataSet lines 450-463:
450: repeat
iPos := Pos(';', DependEvents);
...
463: until iPos = 0;
where DependEvents is a property of TCustomSmartQuery.
So if DependEvents contains ';' then it goes infinitely.
2.OraSmart InternalPost lines 1311-1321:
(internal procedure DoRestoreReadOnly)
1315: SetLength(SaveReadOnly, 0);
1316: DisableControls;
1317: for i := 0 to FieldCount - 1 do
1318: if Fields.FieldKind = fkData then
-- here should be Fields.Fields...
1319: Fields.ReadOnly := SaveReadOnly;
-- here should be Fields.Fields..., also SaveReadOnly is empty here.