May be error in NonBlocking realization?

[eml79]

ODAC version 6.25.2.15
Module OraClasses.pas

Code: Select all

constructor TExecThread.Create(MethodDesc: TMethodDesc; CreateSuspended: Boolean);
begin
  inherited Create(CreateSuspended);

  FMethodDesc := MethodDesc;
  FreeOnTerminate := True;
end;

In TOCIConnection.RunThread you call TExecThread.Create with CreateSuspended = False. Variable FMethodDesc assigned after of thread started and IMHO may be undefined in method TExecThread.Execute.
May be this is a bug?

[Plash]

This is not a bug. The thread is started in the AfterConstruction method of TThread. This method is executed after the constructor.

[eml79]

The thread is started in the AfterConstruction method of TThread. This method is executed after the constructor.

Delphi 5

Code: Select all

constructor TThread.Create(CreateSuspended: Boolean);
var
  Flags: DWORD;
begin
  inherited Create;
  AddThread;
  FSuspended := CreateSuspended;
  Flags := 0;
  if CreateSuspended then Flags := CREATE_SUSPENDED;
  FHandle := BeginThread(nil, 0, @ThreadProc, Pointer(Self), Flags, FThreadID);
end;

BeginThread call CreateThread. The thread is started in the Create method. (not in AfterConstruction)

[Plash]

Such code is only in Delphi 5. In newer versions of Delphi the thread is started in the AterConstruction method.
We'll fix our code to make it work correctly in Delphi 5.