Bugs found in source code of OraSmart

Discussion of open issues, suggestions and bugs regarding ODAC (Oracle Data Access Components) for Delphi, C++Builder, Lazarus (and FPC)
Post Reply
ac
Posts: 32
Joined: Mon 16 Jan 2006 12:56

Bugs found in source code of OraSmart

Post by ac » Tue 16 May 2006 07:24

Hi!

We think, we found 2 bugs in OraSmart. Please confirm:

1. OraSmart RegisterDataSet lines 450-463:

450: repeat
iPos := Pos(';', DependEvents);
...
463: until iPos = 0;
where DependEvents is a property of TCustomSmartQuery.
So if DependEvents contains ';' then it goes infinitely.


2.OraSmart InternalPost lines 1311-1321:

(internal procedure DoRestoreReadOnly)
1315: SetLength(SaveReadOnly, 0);
1316: DisableControls;
1317: for i := 0 to FieldCount - 1 do
1318: if Fields.FieldKind = fkData then
-- here should be Fields.Fields...
1319: Fields.ReadOnly := SaveReadOnly;
-- here should be Fields.Fields..., also SaveReadOnly is empty here.

Challenger
Devart Team
Posts: 925
Joined: Thu 17 Nov 2005 10:53

Post by Challenger » Tue 16 May 2006 09:17

Thank you for assistance. We will include fixes of these bugs in the next build of ODAC.

ac
Posts: 32
Joined: Mon 16 Jan 2006 12:56

Post by ac » Fri 19 May 2006 15:05

AFAICS the fixes are not included in 5.70.1.32 (18.05.06). Right?

Challenger
Devart Team
Posts: 925
Joined: Thu 17 Nov 2005 10:53

Post by Challenger » Thu 25 May 2006 09:02

Current build includes fixes of these bugs but we
will describe them in history in next build.

Post Reply