Devart Forums

I am right now evaluating RA. I will use it with TFS-Repository. I've already activated the "PreCommit Review"-Policy.
I am using Visual Studio 2017.

Is it possible to forbid that reviewer is the same user as the author?

After changing some files: i double-clicked the "There are files that require the code review. ...".
-> this took me to the code review board where i entered a title and some comment and pressed "Create".
-> The reviewer completed (accepted the changes) the review and closed it.
-> But the "There are files that require the code review...." Message is still there and i cann't check in!

Any help welcome!

Thx

Hi,

The warning will be changed after refreshing the Team Explorer panel.

It didn't work. The warning is still there.

1st case: i am the author and the reviewer. The warning is still there, even after refresh.

2nd case: author and reviewer are different users. The warning disappears after pressing the "check-in" button several times.

Hi,

Unfortunately, we cannot reproduce this issue. The policy works correctly in both cases. Could you provide us with the following information:

1 A screenshot of the project's repository options
2 A screenshot of the Source Control Explorer window with the source and local paths
3 A screenshot of the created, accepted and closed review on the Code Review Board (the review filter My Archive)
4 A screenshot of Pending Changes panel with the warning

Please, sent the reply with the attachments to https://www.devart.com/company/contactform.html

I tried it now on 3 different PCs:
- On my PC i was able to finish the check-in by repeatedly pressing the "CheckIn"-Button (~10 times) until the warning message disappeared and checkin got through.
- On 2nd PC same situation as on my PC
- On 3rd PC (VMware) there was no problem with the checkin.

AticAtac wrote: ↑Thu 05 Jul 2018 11:15 I tried it now on 3 different PCs:
- On my PC i was able to finish the check-in by repeatedly pressing the "CheckIn"-Button (~10 times) until the warning message find results of phenq here disappeared and checkin got through.
- On 2nd PC same situation as on my PC
- On 3rd PC (VMware) there was no problem with the checkin.

What version of Windows are you using? Asking because I faced lots of problems with RA as well as some of the other software as soon as I upgraded to Win 10. Switched back to Win 7 and all problems were gone. Seems unrelated, but it solved my problem. Sill using Win 7.

I am using Windows 10.

JackieWeyand wrote: ↑Tue 21 Aug 2018 06:24

AticAtac wrote: ↑Thu 05 Jul 2018 11:15 I tried it now on 3 different PCs:
- On my PC i was able to finish the check-in by repeatedly pressing the "CheckIn"-Button (~10 times) until the warning message disappeared and checkin got through.
- On 2nd PC same situation as on my PC
- On 3rd PC (VMware) there was no problem with the checkin.

What version of Windows are you using? Asking because I faced lots of problems with RA as well as some of the other software as soon as I upgraded to Win 10. Switched back to Win 7 and all problems were gone. Seems unrelated, but it solved my problem. Sill using Win 7.

We use Review Assistant on Win 10 without problems. You wrote that you faced with a lot of problems in Win10. Could you explain your problems in more details?

Best regards,
Mstislav Sakidon
Devart Team
www.devart.com

I'm having similar problems with Windows 10, but not with Windows Server 2016:

Can't check-in/check-in policy is never satisfied (Team Explorer always shows "There are files that require the code review...") - this has been verified on 2 other Windows 10 machines as well:
- Windows 10 - Version 1803 (OS Build 17134.228)
- Visual Studio Enterprise 2017 - Version 15.7.3
- .NET Framework 4.7.03056

Works fine - after review is closed, check-in policy is met
- Windows Server 2016 - Version 1607 (OS Build 14393.2248)
- Visual Studio Enterprise 2017 - Version 15.6.0
- .NET Framework 4.7.03062

I've sent off several email messages to [email protected] - waiting for a response. Meanwhile can anyone provide any things to check\try?

I am having this what may be a related issue. I installed the evaluation copy; I did do a server and client install. Client is my machine (Windows 7, Visual Studio 2017) and server is Windows 2012 R2.

I am having 2 problems:

• Most the time I cannot "Accept" or "Reject" changes. These options are not present, the "Complete Review" (it isn't even a dropdown)

• Even when I Accepted the Check In Policy is never satisfied.

Edit: I realized now that the Accepted or Rejected appears to be happening automatically if I don't add comments (or do). However, the check in policy is still never satisfied.

Please, send the following information to us:

1. The screenshots or a video which shows:
- the TFS repository settings in the Review Assistant options,
- Source Location and the Local Path in the Source Control Explorer
- steps to reproduce the issue.

2. File C:\%AppData%\Devart\Review Assistant\review-cache.xml.

Please, send this information to [email protected].