Some questions

Discussion of open issues, suggestions and bugs regarding code review tool for Visual Studio – Review Assistant
Post Reply
AticAtac
Posts: 3
Joined: Tue 19 Jun 2018 12:09

Some questions

Post by AticAtac » Tue 19 Jun 2018 12:23

I am right now evaluating RA. I will use it with TFS-Repository. I've already activated the "PreCommit Review"-Policy.
I am using Visual Studio 2017.

Is it possible to forbid that reviewer is the same user as the author?

After changing some files: i double-clicked the "There are files that require the code review. ...".
-> this took me to the code review board where i entered a title and some comment and pressed "Create".
-> The reviewer completed (accepted the changes) the review and closed it.
-> But the "There are files that require the code review...." Message is still there and i cann't check in!

Any help welcome!

Thx

SvetlanaL
Posts: 33
Joined: Mon 06 Feb 2017 09:00

Re: Some questions

Post by SvetlanaL » Wed 20 Jun 2018 08:34

Hi,

The warning will be changed after refreshing the Team Explorer panel.

AticAtac
Posts: 3
Joined: Tue 19 Jun 2018 12:09

Re: Some questions

Post by AticAtac » Wed 20 Jun 2018 14:16

It didn't work. The warning is still there.

1st case: i am the author and the reviewer. The warning is still there, even after refresh.

2nd case: author and reviewer are different users. The warning disappears after pressing the "check-in" button several times.

SvetlanaL
Posts: 33
Joined: Mon 06 Feb 2017 09:00

Re: Some questions

Post by SvetlanaL » Wed 27 Jun 2018 15:24

Hi,

Unfortunately, we cannot reproduce this issue. The policy works correctly in both cases. Could you provide us with the following information:

1 A screenshot of the project's repository options
2 A screenshot of the Source Control Explorer window with the source and local paths
3 A screenshot of the created, accepted and closed review on the Code Review Board (the review filter My Archive)
4 A screenshot of Pending Changes panel with the warning

Please, sent the reply with the attachments to https://www.devart.com/company/contactform.html

AticAtac
Posts: 3
Joined: Tue 19 Jun 2018 12:09

Re: Some questions

Post by AticAtac » Thu 05 Jul 2018 11:15

I tried it now on 3 different PCs:
- On my PC i was able to finish the check-in by repeatedly pressing the "CheckIn"-Button (~10 times) until the warning message disappeared and checkin got through.
- On 2nd PC same situation as on my PC
- On 3rd PC (VMware) there was no problem with the checkin.

Post Reply