missing feature: set-method access-modifier

Discussion of open issues, suggestions and bugs regarding Entity Developer - ORM modeling and code generation tool
Post Reply
mindplay
Posts: 148
Joined: Tue 13 Dec 2011 22:58
Location: Ithaca, NY

missing feature: set-method access-modifier

Post by mindplay » Wed 28 Dec 2011 20:04

On properties (and relation-properties) we have the Modifier setting, which can be configured as Public, Private, Protected, etc.

The problem with that, is that in C# we actually have two access-modifiers, one for the get-method and one for the set-method.

About 75% of the time, these are probably going to be identical - but I have many cases (in an existing model I'm currently rebuilding in ED) where the get-method has a lower access-modifier, e.g. public get and protected set.

To properly support C# accessors, we need something like a SetModifier setting - this could be left empty (or have an additional option called "Same") and by default would use the Modifier setting for the most common cases where both methods have the same access-modifier...

Shalex
Site Admin
Posts: 8241
Joined: Thu 14 Aug 2008 12:44

Post by Shalex » Thu 29 Dec 2011 10:04

Thank you for your suggestion. We will investigate the possibility of implementing this feature and post here about the results.

Helen
Devart Team
Posts: 127
Joined: Wed 07 Sep 2011 11:54

Post by Helen » Thu 05 Jan 2012 15:03

Behaviour is changed: 'Getter Modifier' and 'Setter Modifier' code generation properties are added for entity properties instead of the 'Modifier' property.

This changed behaviour will be available in the next build.

Helen
Devart Team
Posts: 127
Joined: Wed 07 Sep 2011 11:54

Post by Helen » Thu 12 Jan 2012 15:31

New version of Entity Developer 4.2.110 is released!

It can be downloaded from http://www.devart.com/entitydeveloper/download.html (trial version) or from Registered Users' Area (for users with valid subscription only).
For more information, please refer to http://www.devart.com/forums/viewtopic.php?t=23135 .

mindplay
Posts: 148
Joined: Tue 13 Dec 2011 22:58
Location: Ithaca, NY

Post by mindplay » Tue 17 Jan 2012 19:38

This works, but only for regular properties - please, could you add this feature for navigation properties, too?

(wondering what your implementation looks like - I would have assumed you have a common base-class for properties and navigation-properties, but I'm starting to think you don't? Documentation for navigation properties was also a miss. It seems like both are properties and they have a lot of things in common - maybe it's time to think about some refactoring to provide more consistency in the model? in C# and NH, navigation and regular properties have many, if not most, things in common...)

Helen
Devart Team
Posts: 127
Joined: Wed 07 Sep 2011 11:54

Post by Helen » Wed 18 Jan 2012 08:41

We will implement this feature and inform you when the build containing the fix is published.

Helen
Devart Team
Posts: 127
Joined: Wed 07 Sep 2011 11:54

Post by Helen » Fri 27 Jan 2012 15:30

mindplay wrote: This works, but only for regular properties - please, could you add this feature for navigation properties, too?
This feature is available in the latest 4.2.120 build of Entity Developer.

The new build can be downloaded from http://www.devart.com/entitydeveloper/download.html (the trial and free versions) or from Registered Users' Area (provided that you have an active subscription).

For more information, please refer to http://www.devart.com/forums/viewtopic.php?t=23252 .

Post Reply