Installing UniDAC from source and PostgreSQL memleak

[intelw]

Hello. Fisrt of all, great job!
I'm Delphi XE developer.

1. I'm always installing UniDAC manually using dpk files since version 4.6.12 (my current version is 5.1.4). I would like to ask you to remove BPL output definition (<DCC_BplOutput>.</DCC_BplOutput>) from "myprovider150.dproj" file (only mysql provider has this definition), because after build/compile operation during install, BPL always stays in the source directory when it should be inside user common BPL's directory. Very annoying.

2. There is a memleak appears starting from 5.0.2 version in PostgreSQL provider and still not fixed in 5.1.4. The reason is line duplication inside "PostgreSQLUniProvider.pas" file:

Code: Select all

function TPostgreSQLUniProvider.GetConnectionOptions: TOptionsList;

...

// following line was added twice and it is the reason of memleak
FConnectionOptions.Add(TEnumeratorOption.Create('ProtocolVersion', prProtocolVersion, [TPgSQLConnection, TPgConnectionParameters], Variant(pv30), TypeInfo(TProtocolVersion), True));
FConnectionOptions.Add(TEnumeratorOption.Create('ProtocolVersion', prProtocolVersion, [TPgSQLConnection, TPgConnectionParameters], Variant(pv30), TypeInfo(TProtocolVersion), True));

  {$IFNDEF CLR}
...

Thanks.

[AlexP]

Hello,

Thank you for the information, we have already fixed both problems, these fixes will be added to the next UniDAC version.