Internal Error for Deleted Files

Discussion of open issues, suggestions and bugs regarding code review tool for Visual Studio – Review Assistant
Post Reply
lordneeko
Posts: 26
Joined: Fri 19 Dec 2014 16:58

Internal Error for Deleted Files

Post by lordneeko » Wed 11 Mar 2015 14:09

If file deletes are pending, the Review Assistant Pre-commit check-in gate gives an error
"Internal error in The policy forces users to review code using Review Assistant before check-in. Could not find file '<file path\name>' "
There are a couple of ways that this error manifests itself.

Repro Steps:
0) With no other pending changes,
1) Delete a file in TFS source control
2) In Pending Changes, Refresh
3) Error message appears

Repro Steps:
1) Have other "non-delete" pending changes
2) Delete a file in TFS Source Control
3) In Pending Changes, click refresh
4) Error message appears

Repro Steps:
1) Have other "non-delete" pending changes
2) Delete a file in TFS Source Control
3) In Pending Changes, DO NOT click refresh
4) Double click pre-commit message top start review
5) Code Review board opens and looks like it is going to work
6) Click "Create"
7) Review Assistant-> Unhandled Exception
7a) Details "Message: Could not find file '<path\file>'"
8) Click "Close"
9) Review IS created, successfully
10) Clicking on the deleted file opens the compare tool without issues
11) Accept/Close review all generate the same Unhandled Exception as above
12) Review Completes Successfully
13) Still cannot check-in however, because the Pending Changes window now shows
"Internal error in The policy forces users to review code using Review Assistant before check-in. Could not find file '<file path\name>' "

AlexeyN
Devart Team
Posts: 244
Joined: Wed 12 Sep 2012 12:09

Re: Internal Error for Deleted Files

Post by AlexeyN » Thu 12 Mar 2015 11:20

Thank you for such a detailed response. We will take a closer look at your problem ASAP.

Post Reply