Compare Base and Last Revisions

Compare Base and Last Revisions

Postby nickdodd79 » Wed 09 Jul 2014 23:50

Hi,

We are using Review Assistant for our code review activities and have a query around comparing a base revision with the latest.

If a revision is added, say 123, and the review is submitted, then the slider control will show 122-123. This is fine when choosing the 'Compare Base and Last Revisions' as we can see the intended diff for the work done.

However, if another revision is added, say 987, for some review rework, then the slider control only allows me to select the revision range of 123-987. This means when I select 'Compare Base and Last Revisions' it is showing ALL changes made by ALL authors in the revision range.

This makes it difficult to determine what should be reviewed, and means comments are being added to the wrong review (where another review exists for a code change highlighted in the diff).

Is there a way to get the slider to show the files for only the 987 revision, which in turn means selecting 'Compare Base and Last Revisions' shows the diff between 986 and 987.

What we would find useful is a way to set the revision range to the same revision for both the minimum and maximum values, as at the moment we can't review a revision to its immediate previous when multiple revisions have been added.

Thanks,

Nick.
nickdodd79
 
Posts: 1
Joined: Wed 09 Jul 2014 23:07

Re: Compare Base and Last Revisions

Postby AlexeyN » Mon 14 Jul 2014 10:31

Hello,

As a workaround, you can add the 986 revision (base for 987) - and then add the 987 revision. So, you will be able to set a range of 986 - 897 - and your comparison will work as you need.
AlexeyN
Devart Team
 
Posts: 244
Joined: Wed 12 Sep 2012 12:09

Re: Compare Base and Last Revisions

Postby mollycook » Tue 09 Sep 2014 10:18

Hi,

This is starting to become an issue for us. When you suggest to add the previous changeset are you referring to when the code review is created? Once created we only seem to be able to add newer changesets.

Thanks,

Molly
mollycook
 
Posts: 1
Joined: Tue 09 Sep 2014 10:16

Re: Compare Base and Last Revisions

Postby AlexeyN » Mon 15 Sep 2014 11:18

We encounter the same problem sometimes, and we will think, how to fix it.

When creating review, author can add 'revision-1' to the review and then add his/her 'revision'. So, you will be able to set the 'revision-1 - revision' range at the revision range slider and comparison will work in the way you need.

If author forgets to add two revisions bunch, reviewer can replace author's revision with 'revision-1', and then add 'revision' to the review.
AlexeyN
Devart Team
 
Posts: 244
Joined: Wed 12 Sep 2012 12:09

Re: Compare Base and Last Revisions

Postby kubaj » Wed 05 Nov 2014 08:15

kubaj
 
Posts: 1
Joined: Wed 05 Nov 2014 08:13


Return to Review Assistant