Question on using the Review Assistant - 'Accept Changes'

[udayr]

Hi,

I have quick question on using the Review Assistant.

When the author requests for a review, does the reviewer rejects the changes even if he has just comments? or the rejects only when there is 'defect' found?

In short, do the reviewer 'Accept Changes' only when there are absolutely no comments or defects?

Thanks for you time.

Uday

[AlexeyN]

It strictly depends on your needs. For example, in our team, reviewer sets author as a moderator and accepts review, when reviewer agrees with code but wants from reviewer to do some unimportant changes (e.g. move or rename method). This solution guarantees that reviewer will see those comments.

[udayr]

It strictly depends on your needs. For example, in our team, reviewer sets author as a moderator and accepts review, when reviewer agrees with code but wants from reviewer to do some unimportant changes (e.g. move or rename method). This solution guarantees that reviewer will see those comments.

Thanks Alexey for the response. It helps.

I think you used 'reviewer' instead of 'author' in your response above. I am correcting it based on what I understood. Correct me if I am wrong.

It strictly depends on your needs. For example, in our team, reviewer sets author as a moderator and accepts review, when reviewer agrees with code but wants from author to do some unimportant changes (e.g. move or rename method). This solution guarantees that author will see those comments.

[AlexeyN]

Yes, you are correct!